Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a final-ish draft of creating an error type for Calloop that covers all the major use cases (internal and external). The two things holding it back from not being a draft are:
Sorry it took so long, it was hard to accommodate certain niche cases. I think I've made it as ergonomic as possible.
The basic gist is:
calloop::errors::Error
which can take conversions fromstd::io::Error
and anything that converts intoBox<dyn Error + Sync + Send>
.InsertError
, because it's a bit special but rare.?
and not worry about mapping to and from IO errors etc.I've used
thiserror
where possible to remove some boilerplate, it's worked quite nicely but is the source of the tarpaulin issue.