Please sign in to comment.
Fix M958 Set Spindle PID Parameters
Original code sets the P term to any values provided for P, I, or D with no way to set I or D terms. This change sets I and D correctly as one would expect when I and D are passed to M958. The set_i_term() and set_d_term() functions already existed, so the layout in on_gcode_received() was likely a simple oversight by the original author. I tested this change on the bench with a Smoothieboard driving an MC2100 DC controller hooked up to a 2HP treadmill motor. Prior to the change, M958 would only set the P term. After the change, M958 works as expected and the PID controller can be tuned live.
- Loading branch information...
Showing with 2 additions and 2 deletions.