Skip to content

fix: Axe DevTools Critical Issues #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2021

Conversation

yamanoku
Copy link
Contributor

@yamanoku yamanoku commented Jul 3, 2021

Details

Use to axe DevTools to resolve critical accessibility issues.

Buttons must have discernible text

Added identifiable text to the clipboard button (679ddc5).

At first I tried to solve this using aria-label, but @shopify/jsx-no-hardcoded-content rule didn't allow me to override it, so I modified it to include the text and make it sr-only readable.

Images must have alternate text

Added information about what this img is by adding the title attribute (b09f4af).

Normally, it would be a good idea to add an alt attribute, but since this is an image generator, the meaning of the image will also change each time it is generated.
This critical issue was resolved by using the title attribute instead of the alt attribute, referring to the Living Standard's Images whose contents are not known section.
A better thing to do would have been to describe the image in <figcaption>, but that would have changed the look of the site, so I didn't go that far to fix it.

Results

Currently Fixed
Currently: Axe DevTools Issues Screenshot Fixed: Axe DevTools Issues Screenshot

@vercel
Copy link

vercel bot commented Jul 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sno2wman/tohohoify/fauk68qn7YEsN5avSE1j2xAy9DT7
✅ Preview: https://tohohoify-git-fork-yamanoku-fix-a11y-critical-error-sno2wman.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants