Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fixed paths to isdir.py and dependencies when building as meson subproject #328

Merged
merged 1 commit into from Jan 2, 2020

Conversation

@tsieprawski
Copy link
Contributor

tsieprawski commented Jan 2, 2020

Fixes #327

@Snaipe
Snaipe approved these changes Jan 2, 2020
Copy link
Owner

Snaipe left a comment

LGTM. Thanks for the fix!

'../dependencies/nanopb/pb_common.c',
'../dependencies/nanopb/pb_encode.c',
'../dependencies/nanopb/pb_decode.c',
meson.current_source_dir() + '/../dependencies/nanopb/pb_common.c',

This comment has been minimized.

Copy link
@Snaipe

Snaipe Jan 2, 2020

Owner

Mmh, yeah, maybe it'll be better to move these types of libs under ./src, or make them full blown deps. Nanopb recommends compiling these files directly into the project, but I think I'd rather build a static lib.

For now, I'm fine with this coming in as-is.

@Snaipe Snaipe merged commit 0e2d53e into Snaipe:bleeding Jan 2, 2020
6 checks passed
6 checks passed
Alpine (gcc,i386) Task Summary
Details
Alpine (gcc,x86_64) Task Summary
Details
Debian (gcc) Task Summary
Details
FreeBSD Task Summary
Details
MacOS Task Summary
Details
Windows (mingw-gcc) Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.