Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nanopb and link against lib. #333

Open
wants to merge 3 commits into
base: bleeding
from
Open

Update nanopb and link against lib. #333

wants to merge 3 commits into from

Conversation

@Snaipe
Copy link
Owner

Snaipe commented Jan 6, 2020

This partially addresses #332

Snaipe added 3 commits Jan 6, 2020
This does two things: first, we stop manually including nanopb sources
in the project, and we link against nanopb.

Second, we use a fallback wrap of nanopb, which we statically build if
we can't find the library locally. In doing so, we remove the nanopb
submodule.
This allows us to keep using the bootstrap criterion.pb.[ch] files
but still use whatever system-provided nanopb is available otherwise.

Not regenerating in the latter case would have a high chance of breaking
the build.
@Snaipe Snaipe force-pushed the nanopb-wrap branch from b4ea2c5 to 3f7b984 Jan 7, 2020
@Snaipe

This comment has been minimized.

Copy link
Owner Author

Snaipe commented Jan 9, 2020

Whoa. What's up with these runtimes on FreeBSD? Either the new nanopb is slow as hell, or something is very wrong.

@Snaipe

This comment has been minimized.

Copy link
Owner Author

Snaipe commented Jan 10, 2020

Okay, so we either have a race condition somewhere in the FreeBSD build, or we suffer from bad performance on the cirrus CI hosts somehow. I think it's a separate issue though, so I think this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.