Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separating files #8

Merged
merged 2 commits into from Dec 9, 2019
Merged

separating files #8

merged 2 commits into from Dec 9, 2019

Conversation

@cagomezr
Copy link
Contributor

cagomezr commented Dec 4, 2019

Separating files according to issue #7

the only part I'm concerned( due to set up) is if my links to the CSS and JavaScript are correct

they are made as
style.css as the CSS files
script.js as the JavaScript scripts

please let me know.

Separating files
Copy link
Collaborator

j-99 left a comment

Did you check by running it with the server? You'll have to put the files in the right directory perhaps. Please check.. cheers

While it worked I think the issue I had was that you had  other scripts and wallpapers on, static, so I decided to move everything to static.
@cagomezr

This comment has been minimized.

Copy link
Contributor Author

cagomezr commented Dec 5, 2019

I did a quick test and changed folders so it follows the location of your static folder, which I believe may have been why I was worried, it looks good, but I as a rule don't trust my environment -I been having enviroment issues with python and react lately.

@j-99

This comment has been minimized.

Copy link
Collaborator

j-99 commented Dec 6, 2019

Great Job @cagomezr !! I'll test the files and let you know. Thanks for the efforts !!

@j-99 j-99 merged commit f249a2c into Snehal-Reddy:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.