Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and process satellite elements from zone group state #245

Merged
merged 6 commits into from Nov 29, 2014

Conversation

Projects
None yet
4 participants
@simonalpha
Copy link
Contributor

commented Oct 12, 2014

Alters _parse_zone_group_state method in SoCo to parse Satellite elements (nested in ZoneGroupMember elements, representing home theatre rear speakers or subwoofers), instantiate, and include them in zone sets, groups, etc.

Simon Belluzzo added some commits Sep 23, 2014

Simon Belluzzo
Alter ZGS tests to include satellite speakers.
Modification of zone group topology tests in preparation for adding parsing of
satellite elements in zgs state XML.
Simon Belluzzo
Add Satellite element parsing in ZoneGroupState
SoCo instances are now created for nested Satellite elements in ZGS XML
if present, and added to all_zones and member sets.
Simon Belluzzo
Refactor _parse_zone_group_state for deduplication
Logic shared between the loop parsing member elements and the inner loop
parsing nested satellite elements pulled out into an additional private method.
Simon Belluzzo
Merge upstream master into satellites-from-zgs
Conflicts:
	unittest/test_core.py
@coveralls

This comment has been minimized.

Copy link

commented Oct 12, 2014

Coverage Status

Coverage increased (+0.14%) when pulling 93e0104 on simonalpha:satellites-from-zgs into 44d36f2 on SoCo:master.

Simon Belluzzo
@coveralls

This comment has been minimized.

Copy link

commented Oct 18, 2014

Coverage Status

Coverage increased (+0.17%) when pulling a737af3 on simonalpha:satellites-from-zgs into 44d36f2 on SoCo:master.

@KennethNielsen KennethNielsen referenced this pull request Nov 11, 2014

Closed

Release 0.10 #238

@stefankoegl stefankoegl added this to the 0.11 milestone Nov 16, 2014

@stefankoegl

This comment has been minimized.

Copy link
Member

commented Nov 17, 2014

Nice work, +1

@stefankoegl

This comment has been minimized.

Copy link
Member

commented Nov 17, 2014

Can you please add a short summary that should go into the release notes, either here or to #261

@simonalpha simonalpha referenced this pull request Nov 21, 2014

Closed

Release notes 0.11 #261

@lawrenceakka

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2014

  • 1 from me. Will commit in a few days unless any objections!

lawrenceakka added a commit that referenced this pull request Nov 29, 2014

Merge pull request #245 from simonalpha/satellites-from-zgs
Parse and process satellite elements from zone group state

@lawrenceakka lawrenceakka merged commit f2cfafd into SoCo:master Nov 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@simonalpha simonalpha deleted the simonalpha:satellites-from-zgs branch Dec 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.