Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test clean up #309

Merged
merged 2 commits into from Jun 5, 2015

Conversation

Projects
None yet
2 participants
@KennethNielsen
Copy link
Member

commented Jun 2, 2015

This is a simple pull request that removes some old un-used stuff.

First and foremost it removes all the tests for the old data structures. It seems pretty clear that the new data structures are much better and they already have full test coverage, so there really is no reason to keep them around, and I was getting annoyed with all those XFAIL in the test output.

The second removal is the old hand written test execution script that I wrote before learning about pytest and likes. This has not been used in ages and should be thrown out.

Let me know what you think.
Regards Kenneth

@stefankoegl

This comment has been minimized.

Copy link
Member

commented Jun 2, 2015

+1

@KennethNielsen

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2015

I'll assume that a single +1 in 3 days is enough for this simple cleanup and merge. If anyone disagrees just shout out.

KennethNielsen added a commit that referenced this pull request Jun 5, 2015

Merge pull request #309 from KennethNielsen/test_clean_up
Test clean up, remove tests for old data structures and old hand-written test execution script

@KennethNielsen KennethNielsen merged commit 6f7ce14 into SoCo:master Jun 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stefankoegl stefankoegl added this to the 0.11 milestone Jun 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.