Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for sonos playlist container UPnP class #438

Merged
merged 2 commits into from Oct 26, 2016

Conversation

Projects
None yet
4 participants
@bjarniivarsson
Copy link
Contributor

commented Oct 25, 2016

Ran into a problem when subscribing to events on avTransport:

Traceback (most recent call last):
File "/usr/lib/python3.4/socketserver.py", line 613, in process_request_thread
self.finish_request(request, client_address)
File "/usr/lib/python3.4/socketserver.py", line 344, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python3.4/socketserver.py", line 669, in init
self.handle()
File "/usr/lib/python3.4/http/server.py", line 398, in handle
self.handle_one_request()
File "/usr/lib/python3.4/http/server.py", line 386, in handle_one_request
method()
File "/usr/lib/python3.4/site-packages/soco/events.py", line 227, in do_NOTIFY
variables = parse_event_xml(content)
File "/usr/lib/python3.4/site-packages/soco/events.py", line 130, in parse_event_xml
value = from_didl_string(value)[0]
File "/usr/lib/python3.4/site-packages/soco/data_structures.py", line 98, in from_didl_string
raise DIDLMetadataError("Unknown UPnP class: %s" % item_class)
soco.exceptions.DIDLMetadataError: Unknown UPnP class: object.container.playlistContainer.sonos-favorite

This PR adds support for the unknown UPnP class.

@coveralls

This comment has been minimized.

Copy link

commented Oct 25, 2016

Coverage Status

Coverage increased (+0.03%) to 60.164% when pulling b1fde10 on bjarniivarsson:sonos-favorite-container into e659367 on SoCo:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Oct 25, 2016

Coverage Status

Coverage increased (+0.03%) to 60.164% when pulling b1fde10 on bjarniivarsson:sonos-favorite-container into e659367 on SoCo:master.

@bjarniivarsson bjarniivarsson referenced this pull request Oct 26, 2016

Merged

Sonos responsiveness improvements + enhancements #4063

1 of 1 task complete
@KennethNielsen

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

Nice catch. Only comment is, that to keep the naming convention from the other -sonos-favorite Didl classes, I guess the Python class should be named DidlPlaylistContainerFavorite.

@coveralls

This comment has been minimized.

Copy link

commented Oct 26, 2016

Coverage Status

Coverage increased (+0.03%) to 60.164% when pulling cf8c270 on bjarniivarsson:sonos-favorite-container into e659367 on SoCo:master.

@KennethNielsen KennethNielsen merged commit e17ef88 into SoCo:master Oct 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@KennethNielsen

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

Merged. Thanks. Can you add a comment to the release notes issue #440 about the change please?

@bjarniivarsson

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2016

Thanks for merging. When do you expect to make a release with these changes, I ask since I now have a dependency on them and pointing to a released version of SoCo is so much cleaner than pointing to a specific commit.

@KennethNielsen

This comment has been minimized.

Copy link
Member

commented Oct 27, 2016

We actually just released a version. I would like a shorter release cycle
this time, but that will require some more changes to make it in. I'm
afraid at this point I cannot say.

Regards Kenneth

2016-10-27 9:04 GMT+02:00 Bjarni Ivarsson notifications@github.com:

Thanks for merging. When do you expect to make a release with these
changes, I ask since I now have a dependency on them and pointing to a
released version of SoCo is so much cleaner than pointing to a specific
commit.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#438 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABiVRBqGjeJ8CHAUF-CJIE1sRHZWerreks5q4Ez4gaJpZM4KgK0i
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.