Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added household_id as optional parameter. #644

Closed
wants to merge 2 commits into from

Conversation

twosky2000
Copy link

Use byte code b'Sonos_7OR7eU' from X-RINCON-HOUSEHOLD: Sonos_7OR7eU.

@twosky2000
Copy link
Author

Sorry for breaking lint. I'm new and would like tips for making my programming style better.

Repalces "if b'Sonos' in data" with "if really_utf8(household_id) in data", where household_id has a default value of "Sonos".
Didn't show up in my local flake8 test.
@pwt
Copy link
Contributor

pwt commented Nov 24, 2020

Note that #733 covers the underlying requirement here. It allows for multi-household discovery, and scanning the network for Sonos devices is the only way I know of finding all households.

Should we close this PR?

@pwt
Copy link
Contributor

pwt commented Dec 3, 2020

I'm going to close this PR, as multi-households are quite well supported in SoCo 0.21 (to be released shortly).

Use the network_scan variants of the discover commands (with multi_household=True) to ensure that all households are discovered.

@pwt
Copy link
Contributor

pwt commented Dec 20, 2022

Note: I've resurrected this feature in PR #939.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants