Add playbar/beam surround mode support #646
Conversation
|
Thank you for submitting this PR! Surround mode certainly is an useful feature, we'll try to get this into SoCo as soon as possible. PS: Don't worry about the failed checks, they are about code you didn't touch. |
manugorre
force-pushed
the
feature-surround_mode
branch
from
a6556f4
to
57d00db
Compare
|
Done 👌 |
|
I unfortunately don't have a playbar or beam. Can someone with a surround setup please test this? |
There was a problem hiding this comment.
I tested this briefly with my setup, the SurroundMode controls the "Music Playback" setting shown in here: https://support.sonos.com/s/article/4804?language=en_US
Here are all the settings available on my beam+play:1 setup:
Surrounds = SurroundEnable (0, 1)
TV level = SurroundLevel (-15 - 15)
Music = MusicSurroundLevel (-15 - 15)
Music Playback = SurroundMode (ambient = 0, full = 1)
Balance left = AudioDelayLeftRear (2 = less than 0,6m, 1 = 0,6-3m, 0 = more than 3m)
Balance right = AudioDelayRightRear (same as above)
edit: I realized that this PR is quite old, @manugorre let me know if you want still to work on this, otherwise I'll make the necessary changes to implement this API :-)
|
|
||
| response = self.renderingControl.GetEQ([ | ||
| ('InstanceID', 0), | ||
| ('EQType', 'SurroundMode') |
There was a problem hiding this comment.
This eqtype exists on my beam, but the phone app's "surround speaker" setting controls SurroundEnable instead of this (on S2 setup). This value controls the music level setting as shown here https://support.sonos.com/s/article/4804?language=en_US .
| def surround_mode(self, surround_mode): | ||
| """Switch on/off the speaker's surround mode. | ||
|
|
||
| :param surround_mode: Enable or disable night mode |
@rytilahti: if you'd like to pick this up, I can help with getting it merged. Note, however, I don't have any kind of Sonos home theatre equipment, so I'm not able to test it. |
Thanks for the offer! I just created a PR to supersede this one here. It's still WIP but I wanted to put it out there for some feedback. Feel free to take a look :-) |
Hey ! i don't use soco anymore, but i still have my home theatre equipment, so i'm able to test your PR, just let me know if you want |
|
Hey, feel free to test the linked PR if you wish to do so, knowing that it works for others would be helpful & encouraging :-) |
|
Looks like this has been implemented and merged in #870. |
Agreed. I'll close it. |
Allow turning the surround mode on/off for soundbar speakers.
Closes #461.