Feature/fix local dev workflow #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to npm link to built files in angular-playground package, instead of copying them
greg-arroyo
previously approved these changes
Aug 16, 2018
Contributor
greg-arroyo
suggested changes
Aug 21, 2018
Contributor
greg-arroyo
left a comment
greg-arroyo
left a comment
There was a problem hiding this comment.
Let's give schematics author (@sulco) kudos for his contribution to this release in CHANGELOG please.
timstoddard
force-pushed
the
feature/fix-local-dev-workflow
branch
from
176627a to
6472fcc
Compare
lurock
approved these changes
Aug 21, 2018
lurock
approved these changes
Aug 21, 2018
greg-arroyo
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the local development issue that we were running into after the upgrade to angular 6. I also fixed a few other bugs that I found with the local development workflow.