From 1278d1b2ac2ffda6241830cf60623ebaafe6a722 Mon Sep 17 00:00:00 2001 From: bsweedler Date: Tue, 20 Feb 2018 23:11:09 -0800 Subject: [PATCH 1/2] reveal thrown error for #95 --- packages/angular-playground/cli/src/serve-angular-cli.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/angular-playground/cli/src/serve-angular-cli.ts b/packages/angular-playground/cli/src/serve-angular-cli.ts index e7a2758f..3e0cda4f 100644 --- a/packages/angular-playground/cli/src/serve-angular-cli.ts +++ b/packages/angular-playground/cli/src/serve-angular-cli.ts @@ -3,7 +3,14 @@ import { spawn, SpawnOptions, ChildProcess } from 'child_process'; import { Config } from './configure'; export async function serveAngularCli(config: Config) { - const args: string[] = configureArguments(config); + let args: string[]; + + try { + args = configureArguments(config); + } catch (err) { + process.stderr.write(err.message + "\n"); + } + const ngServe = spawn('node', args); const write = (handler: any, data: any) => { From 8370085f64b5bfb550f5ffdac7beb11662a5146e Mon Sep 17 00:00:00 2001 From: bsweedler Date: Wed, 21 Feb 2018 23:32:43 -0800 Subject: [PATCH 2/2] changed error reporting console.error and added exit call --- packages/angular-playground/cli/src/serve-angular-cli.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/angular-playground/cli/src/serve-angular-cli.ts b/packages/angular-playground/cli/src/serve-angular-cli.ts index 3e0cda4f..7bc4b4f3 100644 --- a/packages/angular-playground/cli/src/serve-angular-cli.ts +++ b/packages/angular-playground/cli/src/serve-angular-cli.ts @@ -8,7 +8,8 @@ export async function serveAngularCli(config: Config) { try { args = configureArguments(config); } catch (err) { - process.stderr.write(err.message + "\n"); + console.error(err.message); + process.exit(1); } const ngServe = spawn('node', args);