fixed parsing of multiple content sections #5

Merged
merged 2 commits into from Dec 27, 2012

Projects

None yet

2 participants

@chrisumbel
Contributor

the rendering of multiple content sections worked fine, but the parsing did not.

it seemed that a single regex match got the job done -- unless i'm misunderstanding something.

see the specs:
parsing scripts->should parse multiple content sections
parsing scripts->should parse multiple content sections and a body

@Soarez Soarez merged commit fc78129 into Soarez:master Dec 27, 2012

1 check passed

default The Travis build passed
Details
@Soarez
Owner
Soarez commented Dec 27, 2012

I still can't understand what was breaking, the tests you added passed on the previous version (38459ba) on my machine. Nonetheless, you have a good point, it was pretty dumb of me to use that second regex.

Thank you Chris.

@chrisumbel
Contributor

hmm, in that case node version might be relevant. out of curiosity i
might see if any other boxes i have work with 38459ba
38459ba later
today.

thanks for maintaining this project!

On 12/27/12 1:10 PM, Igor Soarez wrote:

I still can't understand what was breaking, the tests you added passed
on the previous version (38459ba
38459ba) on
my machine. Nonetheless, you have a good point, it was pretty dumb of
me to use that second regex.

Thank you Chris.


Reply to this email directly or view it on GitHub
#5 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment