From 31d9b501eeb2ecd491ecb415c032a4b307050511 Mon Sep 17 00:00:00 2001
From: Douglas Duteil <douglasduteil@gmail.com>
Date: Wed, 29 Jul 2020 12:18:57 +0200
Subject: [PATCH] feat(app): allow optional config

---
 src/components/app/index.ts    | 4 ++--
 src/components/hasura/index.ts | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/components/app/index.ts b/src/components/app/index.ts
index 6c1f8bc074..e99000bebe 100644
--- a/src/components/app/index.ts
+++ b/src/components/app/index.ts
@@ -35,7 +35,7 @@ export const create = (
     deployment: deploymentParams,
   }: {
     env: Environment;
-    config: Partial<AppConfig>;
+    config?: Partial<AppConfig>;
     deployment?: Partial<Omit<DeploymentParams, "containerPort">>;
   }
 ): { kind: string }[] => {
@@ -54,7 +54,7 @@ export const create = (
     defaultEnvParams, // set name as default if not provided
     gitlab(process.env),
     env.component(name) as AppConfig, // kosko env overrides
-    config // create options
+    config ?? {} // create options
   );
 
   const { containerPort, servicePort } = envParams;
diff --git a/src/components/hasura/index.ts b/src/components/hasura/index.ts
index 09943466a1..c3d623292b 100644
--- a/src/components/hasura/index.ts
+++ b/src/components/hasura/index.ts
@@ -58,10 +58,9 @@ export const create = (
   ok(deployment);
 
   addPostgresUserSecret(deployment);
-
-  // todo: doesnt work ATM, we need to check if user+db are ready
   addWaitForPostgres(deployment);
 
   //
+
   return manifests;
 };