New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwitterProvider(OAuth1) additional query string #162

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
2 participants
@tomothumb
Contributor

tomothumb commented Apr 5, 2018

TwitterProvider(Oauth1) doesn't compatible an additional query string regardless of having a method with().

Laracast discussion 'Is it possible to use force_login for Twitter in Laravel Socialite?'.
https://laracasts.com/discuss/channels/laravel/is-it-possible-to-use-force-login-for-twitter-in-laravel-socialite

I updating method getAuthorizationUrl().
It allows additional query strings like calling with(['fource_url'=>true]) options as well as ['lang' => 'ja'] option.

if 'SocialiteProviders\Manager\OAuth1\Server' add this function, It might be compatible any other OAuth1 providers.
Please review it. thx.

tomothumb added some commits Apr 5, 2018

TwitterProvider(OAuth1) additional query string
TwitterProvider(Oauth1) doesn't compatible an additional query string regardless of having a method with().

Laracast discussion 'Is it possible to use force_login for Twitter in Laravel Socialite?'.
https://laracasts.com/discuss/channels/laravel/is-it-possible-to-use-force-login-for-twitter-in-laravel-socialite

I updating method getAuthorizationUrl().
It allows additional query strings like calling with(['fource_url'=>true]) options as well as ['lang' => 'ja'] option.

if 'SocialiteProviders\Manager\OAuth1\Server' add this function, It might be compatible any other OAuth1 providers.
Please review it. thx.
@tomothumb

This comment has been minimized.

Contributor

tomothumb commented Apr 5, 2018

@tomothumb

This comment has been minimized.

Contributor

tomothumb commented Apr 23, 2018

@faustbrian
Is there any chance you could be merged? Or Can I hear your thoughts about this PR?

I'm thinking whether I fork and maintenance myself for my product which was implemented this feature.

@faustbrian faustbrian merged commit 0e77bef into SocialiteProviders:master Apr 23, 2018

1 check passed

continuous-integration/styleci/pr The analysis has passed
Details
@tomothumb

This comment has been minimized.

Contributor

tomothumb commented Apr 24, 2018

Thanks. @faustbrian
How does this available from packagist?

@faustbrian

This comment has been minimized.

Contributor

faustbrian commented Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment