Dynamic myshopify.com subdomain #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oauth domain is not a constant with shopify - each store hais on its own subdomain. The current setup of defining a subdomain in the services config array will not work when for example installing an app or sales channel from the Shopify app store. The subdomain value need to be dynamic from the shop GET parameter. This PR swaps out the current subdomain config item for the shop param in the current request. I don't think this is the ideal solution, but it works and at least gets the ball rolling to sort out the issue. I have implemented it to have no breaking changes - if the subdomain is set - that will be used, if not it will fallback to the shop param on the request.
.. I think
so guess work here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oauth domain is not a constant with shopify - each store hais on its own subdomain.
The current setup of defining a subdomain in the services config array will not work when for example installing an app or sales channel from the Shopify app store. The subdomain value need to be dynamic from the shop GET parameter.
This PR swaps out the current subdomain config item for the shop param in the current request.
I don't think this is the ideal solution, but it works and at least gets the ball rolling to sort out the issue.
I have implemented it to have no breaking changes - if the subdomain is set - that will be used, if not it will fallback to the shop param on the request.