refactor: hoist remaining getDefaultLogger() calls #875
+176
−338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes the logger hoisting refactoring started in #229cb0f00 by hoisting
getDefaultLogger()calls in 10 additional command and utility files that were initially missed.Changes
getDefaultLogger().method()callsconst logger = getDefaultLogger()patternFiles Modified
packages/cli/src/commands/analytics/cmd-analytics.mtspackages/cli/src/commands/ci/cmd-ci.mtspackages/cli/src/commands/config/cmd-config-unset.mtspackages/cli/src/commands/logout/cmd-logout.mtspackages/cli/src/commands/manifest/cmd-manifest-setup.mtspackages/cli/src/commands/manifest/run-cdxgen.mtspackages/cli/src/commands/npx/cmd-npx.mtspackages/cli/src/commands/package/fetch-purl-deep-score.mtspackages/cli/src/commands/scan/cmd-scan-github.mtspackages/cli/src/commands/scan/stream-scan.mtsBenefits
Test plan
pnpm buildpnpm run typepnpm run lint