Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting VLAN for Mac OS X using TunTapOSX #10

Merged
merged 1 commit into from Feb 5, 2014

Conversation

@nattoheaven
Copy link
Contributor

nattoheaven commented Jan 14, 2014

In Linux, SoftEther can make virtual NICs using TUN/TAP, and it cannot in OS X. I have wanted to use virtual NICs with TunTapOSX which is the most famous TUN/TAP implementation for OS X (http://tuntaposx.sourceforge.net/).

So I have written a patch implementing virtual NICs based on TunTapOSX. After configure-ing, you can command "make NO_VLAN=" and build the SoftEther software using TunTapOSX.

@dnobori

This comment has been minimized.

Copy link

dnobori commented on 8779e59 Jan 15, 2014

Hi nattoheaven,

Your great patch is much appreciated. I am considering to apply your patch into the SoftEther VPN main tree.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch

You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

This comment has been minimized.

Copy link
Owner Author

nattoheaven replied Jan 15, 2014

Dear Mr. Nobori,

Thank you for your reviewing my patch. And I apologize you for my little understanding about your policy.

I would contribute as the option 1, allowing you to use my patch for commercial products based on non-GPL licenses.

Should you have any more questions needed to apply my patch?

This comment has been minimized.

Copy link

dnobori replied Jan 21, 2014

We are still reviewing your patch. Please wait.

@dnobori
Copy link
Member

dnobori commented Jan 16, 2014

Thank you! We are going to verify your code in order to avoid potential problems. After our verification will complete, we will commit it.

dnobori added a commit that referenced this pull request Feb 5, 2014
Supporting VLAN for Mac OS X using TunTapOSX
@dnobori dnobori merged commit cdd4540 into SoftEtherVPN:master Feb 5, 2014
@dnobori
Copy link
Member

dnobori commented Feb 5, 2014

Thank you so much for your contribution to enrich the SoftEther VPN source code.

Your patch has been merged on the main source-tree of SoftEther VPN.

As a token of our gratitude, your GitHub username has been added on the AUTHORS.TXT file and on the header of the related source file.
Please see: https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT

Thanks again for your contribution.

@nattoheaven
Copy link
Contributor Author

nattoheaven commented Feb 5, 2014

Thank you for your merging my patch to your SoftEther source tree.

When I would recognize what more I could help you, could I contribute you? I wish your softwares get more useful to help more users.

@dnobori
Copy link
Member

dnobori commented Feb 6, 2014

Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.