New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter "ListenIP" to server configuration (vpn_server.config) #202

Merged
merged 3 commits into from Jan 11, 2018

Conversation

Projects
None yet
9 participants
@macvk
Contributor

macvk commented Nov 11, 2015

VPN server listens on specified IP (0.0.0.0 by default)

@dnobori

This comment has been minimized.

Show comment
Hide comment
@dnobori

dnobori May 26, 2016

Member

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch

You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

Member

dnobori commented May 26, 2016

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch

You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

@jbschooley

This comment has been minimized.

Show comment
Hide comment
@jbschooley

jbschooley Dec 1, 2016

Doesn't seem like @macvk is active anymore. Could you guys just add it as option 2 and he can have it changed to option 1 if he wants? I'm eagerly waiting for this too.

jbschooley commented Dec 1, 2016

Doesn't seem like @macvk is active anymore. Could you guys just add it as option 2 and he can have it changed to option 1 if he wants? I'm eagerly waiting for this too.

@ayaz

This comment has been minimized.

Show comment
Hide comment
@ayaz

ayaz Dec 2, 2016

Yes. Please. Can we please go with option 2 for now?

ayaz commented Dec 2, 2016

Yes. Please. Can we please go with option 2 for now?

@macvk

This comment has been minimized.

Show comment
Hide comment
@macvk

macvk Jul 11, 2017

Contributor

yes. please go with option 1.

Contributor

macvk commented Jul 11, 2017

yes. please go with option 1.

@tenten8401

This comment has been minimized.

Show comment
Hide comment
@tenten8401

tenten8401 Jul 26, 2017

This should really be added, would be great for multi-IP setups. 👍

tenten8401 commented Jul 26, 2017

This should really be added, would be great for multi-IP setups. 👍

@aenertia

This comment has been minimized.

Show comment
Hide comment
@aenertia

aenertia Jul 27, 2017

aenertia commented Jul 27, 2017

@macvk macvk changed the title from Added parameter "ListenIP" to server configuration (vpn_server.config) to Add parameter "ListenIP" to server configuration (vpn_server.config) Dec 12, 2017

@qbeukes

This comment has been minimized.

Show comment
Hide comment
@qbeukes

qbeukes Dec 14, 2017

I tested this change and I am now able to configure the binding IP address using the ServerConfiguration->ListenIP property

qbeukes commented Dec 14, 2017

I tested this change and I am now able to configure the binding IP address using the ServerConfiguration->ListenIP property

@moatazelmasry2 moatazelmasry2 merged commit ab4b27a into SoftEtherVPN:master Jan 11, 2018

@moatazelmasry2

This comment has been minimized.

Show comment
Hide comment
@moatazelmasry2

moatazelmasry2 Jan 11, 2018

Member

2 years later, but nevertheless this great PR has finally made it into the code :)
I added your name to the authors list. Thanks again

Member

moatazelmasry2 commented Jan 11, 2018

2 years later, but nevertheless this great PR has finally made it into the code :)
I added your name to the authors list. Thanks again

@theg00s3

This comment has been minimized.

Show comment
Hide comment
@theg00s3

theg00s3 Feb 7, 2018

Is this feature available in the binaries or only if complied from the repo?

theg00s3 commented Feb 7, 2018

Is this feature available in the binaries or only if complied from the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment