Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcppcheck issues #229
Conversation
chipitsine
added some commits
Apr 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dnobori
May 26, 2016
Member
Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.
SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?
|
Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree. SoftEther VPN Patch Acceptance Policy: You have two options which are described on the above policy. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
one |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
any update ? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
chipitsine
commented
Aug 6, 2016
•
edited
Edited 1 time
-
chipitsine
edited Aug 6, 2016 (most recent)
edited
-
Aug 6, 2016 (most recent)
|
knock-knock? |
dnobori
merged commit 5cae447
into
SoftEtherVPN:master
Nov 27, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dnobori
Nov 27, 2016
Member
Thank you so much for your contribution to enrich the SoftEther VPN source code.
Your patch has been merged on the main source-tree of SoftEther VPN.
As a token of our gratitude, your GitHub username has been added on the AUTHORS.TXT file and on the header of the related source file.
Please see: https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT
Thanks again for your contribution.
|
Thank you so much for your contribution to enrich the SoftEther VPN source code. Your patch has been merged on the main source-tree of SoftEther VPN. As a token of our gratitude, your GitHub username has been added on the AUTHORS.TXT file and on the header of the related source file. Thanks again for your contribution. |
chipitsine commentedApr 29, 2016
[src/Cedar/Admin.c:11843] -> [src/Cedar/Admin.c:11845]: (warning) Either the condition 't==0' is redundant or there is possible null pointer dereference: t.
[src/Cedar/Admin.c:12316] -> [src/Cedar/Admin.c:12318]: (warning) Either the condition 'a==0' is redundant or there is possible null pointer dereference: a.
[src/Cedar/Admin.c:12576] -> [src/Cedar/Admin.c:12578]: (warning) Either the condition 't==0' is redundant or there is possible null pointer dereference: t.
[src/Cedar/Admin.c:12790] -> [src/Cedar/Admin.c:12792]: (warning) Either the condition 't==0' is redundant or there is possible null pointer dereference: t.