New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using client parameter in function CtConnect #256

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@cm0x4D
Contributor

cm0x4D commented Oct 3, 2016

Using the global client variable might lead to strange behavoir if multiple clients are allocated and to crashes in the case the client was not initialized with CtStartClient()

Using client parameter in function CtConnect
Using the global client variable might lead to strange behavoir if multiple clients are allocated and to crashes in the case the client was not initialized with CtStartClient()
@cm0x4D

This comment has been minimized.

Show comment
Hide comment
@cm0x4D

cm0x4D Oct 3, 2016

Contributor

Contribution option (1): Allowing us to apply the same patch into PacketiX VPN.

Contributor

cm0x4D commented Oct 3, 2016

Contribution option (1): Allowing us to apply the same patch into PacketiX VPN.

Churro added a commit to w2c/SoftEtherVPN that referenced this pull request Sep 3, 2017

@cm0x4D cm0x4D closed this Sep 28, 2017

@dnobori dnobori reopened this Oct 18, 2017

@dnobori dnobori merged commit b618825 into SoftEtherVPN:master Oct 18, 2017

@dnobori

This comment has been minimized.

Show comment
Hide comment
@dnobori

dnobori Oct 18, 2017

Member

Thank you so much for your contribution to enrich the SoftEther VPN source code.

Your patch has been merged on the main source-tree of SoftEther VPN.

As a token of our gratitude, your GitHub username will be added on the AUTHORS.TXT file and on the header of the related source file.
(It will be done within a few days.)
https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT

Thanks again for your contribution.

Member

dnobori commented Oct 18, 2017

Thank you so much for your contribution to enrich the SoftEther VPN source code.

Your patch has been merged on the main source-tree of SoftEther VPN.

As a token of our gratitude, your GitHub username will be added on the AUTHORS.TXT file and on the header of the related source file.
(It will be done within a few days.)
https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment