New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Radius Delay from counting to next_resend #282

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@NoahO
Contributor

NoahO commented Dec 28, 2016

Hi,

I have found a bug in the IPSec_PPP module, where the packet re-transmission timer is still counting while it is waiting on the radius server.

This causes the MSCHAP start packet to be sent twice, even after authentication has successfully concluded. As it has moved on to IPCP, when the reply comes in from the client, the session is terminated and the connection fails. Therefore, if the radius AUTH takes longer than 1000ms, SSTP/IPsec (PPP-based protocols) fail.

My solution to this is to backup the timer values when a request is received.

I choose Contribution option (1)

Thanks,
Noah

@dnobori

This comment has been minimized.

Show comment
Hide comment
@dnobori

dnobori Oct 18, 2017

Member

Thank you so much for your contribution to enrich the SoftEther VPN source code.

Your patch has been merged on the main source-tree of SoftEther VPN.

As a token of our gratitude, your GitHub username will be added on the AUTHORS.TXT file and on the header of the related source file.
(It will be done within a few days.)
https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT

Thanks again for your contribution.

Member

dnobori commented Oct 18, 2017

Thank you so much for your contribution to enrich the SoftEther VPN source code.

Your patch has been merged on the main source-tree of SoftEther VPN.

As a token of our gratitude, your GitHub username will be added on the AUTHORS.TXT file and on the header of the related source file.
(It will be done within a few days.)
https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment