-
Notifications
You must be signed in to change notification settings - Fork 0
LAB-603 - Update OpenAPI specification for Architecture Report APIs #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- TenantMetadata - SecurityPosture - ArchitectureReport - PrincipalAssignment
…I route. - also replaced nullable: true with type: "null" in PrincipalAssignment schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the OpenAPI specifications in SHIELD.json and Data-Gateway.json to include comprehensive API definitions for Architecture Report endpoints, adding support for storing, retrieving, and managing architectural analysis reports with correlation tracking and tenant-specific access.
- Adds new parameter definitions (tenantId, dateStart, dateEnd) and complete schema definitions for architecture report data structures
- Implements 6 new API endpoints covering POST, GET, and DELETE operations for architecture reports with both tenant-scoped and admin access patterns
- Provides detailed request/response examples and proper schema references for all architecture report components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| specs/SHIELD.json | Adds tenantId parameter, date range parameters, architecture report schemas, and 6 API endpoints for managing architecture reports |
| specs/Data-Gateway.json | Mirrors the SHIELD.json changes with identical architecture report schemas and API endpoints but with "Architecture Report" tag formatting |
Comments suppressed due to low confidence (1)
specs/SHIELD.json:1
- Invalid reference paths - these parameters are defined in the 'query' section, so references should be '#/components/parameters/query/dateStart' and '#/components/parameters/query/dateEnd'.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- also remove the dateStart and dateEnd query parameters definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
According to @pr0uxx and @elliot-huffman this PR and branch will be restored and rebase from main branch. |
for ticket: https://shilab-shicorp.atlassian.net/browse/LAB-603