Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #90

Merged
merged 22 commits into from Oct 14, 2018
Merged

Develop #90

merged 22 commits into from Oct 14, 2018

Conversation

@Wojtek242
Copy link
Contributor

Wojtek242 commented Oct 14, 2018

Quantum Internet Hackthon in Amsterdam 13-14 October

This pull request includes two new protocols added to the CQC pythonLib

  • W State creation
  • Coin flip leader election protocol

Two examples that use these protocols have also been added

  • One example uses the W state to elect a leader
  • The other example runs the coin flip leader election algorithm
@AckslD

This comment has been minimized.

Copy link
Collaborator

AckslD commented Oct 14, 2018

Looks great! :) It would be good if the functions in the protocols have docstrings and comments (what are the arguments and what does it do?) I was also thinking, wouldn't it be nice if there is a function taking a CQCConnection as input and creates a W-state on n qubits and returns these. Then one wouldn't have to first call the initialize_Qubit_register and then create the W-state.

@Wojtek242 Wojtek242 force-pushed the akarazeev:Develop branch 2 times, most recently from c4dd8ae to a425cb2 Oct 14, 2018
@Wojtek242

This comment has been minimized.

Copy link
Contributor Author

Wojtek242 commented Oct 14, 2018

@AckslD, we've updated the code with some docstrings and changed the Wstate API as you asked

@AckslD AckslD merged commit 722be7a into SoftwareQuTech:Develop Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.