New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added maven project model + related ignores #9

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
2 participants
@akraievoy
Contributor

akraievoy commented Sep 19, 2017

now mvn exec:java works, to some extent

added maven project model + related ignores
now mvn exec:java works, to some extent
@akraievoy

This comment has been minimized.

Show comment
Hide comment
@akraievoy

akraievoy Sep 19, 2017

Contributor

well, I have not moved your sources to conform to standard, as the other guy did - so this is easier to integrate

though, I also do find your layout and mixture of tests, resources and other whatnot in one source subfolder to be slightly, well, upsetting

now project does import well and does run locally with mvn exec:java

Contributor

akraievoy commented Sep 19, 2017

well, I have not moved your sources to conform to standard, as the other guy did - so this is easier to integrate

though, I also do find your layout and mixture of tests, resources and other whatnot in one source subfolder to be slightly, well, upsetting

now project does import well and does run locally with mvn exec:java

@SohanChy

This comment has been minimized.

Show comment
Hide comment
@SohanChy

SohanChy Sep 28, 2017

Owner

As I am still a student and really busy with my coursework and sidejobs,
I am having trouble finding the time for this project.
For that I am really sorry.
I will have to go through all of these code smell of mine and fix them sometime in the future.

Owner

SohanChy commented Sep 28, 2017

As I am still a student and really busy with my coursework and sidejobs,
I am having trouble finding the time for this project.
For that I am really sorry.
I will have to go through all of these code smell of mine and fix them sometime in the future.

@SohanChy SohanChy merged commit 970e630 into SohanChy:master Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment