Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default.node_sound_*_defaults are functions, not tables. So add () #10

Closed
wziard opened this issue Jan 13, 2019 · 2 comments
Closed

default.node_sound_*_defaults are functions, not tables. So add () #10

wziard opened this issue Jan 13, 2019 · 2 comments

Comments

@wziard
Copy link

@wziard wziard commented Jan 13, 2019

When I click a mob from mobs_redo with any object from cottages, I get a crash.

This is because default.node_sound_*_defaults are functions, not tables. But they are not called, but copied. Making sounds a function instead of a table.

Patch attached.

[snip] garbled patch deleted

@wziard

This comment has been minimized.

Copy link
Author

@wziard wziard commented Jan 13, 2019

Oh, that patch didn't survive my chain of copy-pasting to get it from my vps to github :-)

patch attached.

patch.txt

@Sokomine

This comment has been minimized.

Copy link
Owner

@Sokomine Sokomine commented Feb 17, 2019

Thank you for noticing that bug! It ought to be fixed in the newest version.
The sounds need some special care as some games (i.e. MC2) do not provide a suitable default mod.

@Sokomine Sokomine closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.