From 7391933d3d91729eb59bd5310a2fac7dd6f1a289 Mon Sep 17 00:00:00 2001 From: ccutullic Date: Tue, 26 Aug 2025 17:19:08 +0200 Subject: [PATCH 1/3] feat (datastructure): initialize the descriptor type of PointCloud data structure to AKAZE by default --- interfaces/datastructure/PointCloud.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interfaces/datastructure/PointCloud.h b/interfaces/datastructure/PointCloud.h index ca9576e7..345fc9bf 100644 --- a/interfaces/datastructure/PointCloud.h +++ b/interfaces/datastructure/PointCloud.h @@ -41,8 +41,8 @@ class SOLARFRAMEWORK_API PointCloud : public Lockable { /// /// @brief PointCloud constructor. - /// - PointCloud() { m_id = 0; }; + /// + PointCloud() { m_id = 0; m_descriptorType = DescriptorType::AKAZE; }; PointCloud(const PointCloud& other): m_pointCloud(other.m_pointCloud), m_descriptorType(other.m_descriptorType), m_id(other.m_id) {}; PointCloud& operator=(const PointCloud& /* other */) { return *this; }; From 70e07fef7cda7eb6a3f2aa1eba652da5d56cbad7 Mon Sep 17 00:00:00 2001 From: ccutullic Date: Wed, 27 Aug 2025 09:06:11 +0200 Subject: [PATCH 2/3] feat (datastructure): change member initialization in PointCloud class --- interfaces/datastructure/PointCloud.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/interfaces/datastructure/PointCloud.h b/interfaces/datastructure/PointCloud.h index 345fc9bf..e6f7c596 100644 --- a/interfaces/datastructure/PointCloud.h +++ b/interfaces/datastructure/PointCloud.h @@ -42,7 +42,7 @@ class SOLARFRAMEWORK_API PointCloud : public Lockable { /// /// @brief PointCloud constructor. /// - PointCloud() { m_id = 0; m_descriptorType = DescriptorType::AKAZE; }; + PointCloud(); PointCloud(const PointCloud& other): m_pointCloud(other.m_pointCloud), m_descriptorType(other.m_descriptorType), m_id(other.m_id) {}; PointCloud& operator=(const PointCloud& /* other */) { return *this; }; @@ -123,8 +123,8 @@ class SOLARFRAMEWORK_API PointCloud : public Lockable { void serialize(Archive &ar, const unsigned int version); std::map> m_pointCloud; - SolAR::datastructure::DescriptorType m_descriptorType; - uint32_t m_id; + SolAR::datastructure::DescriptorType m_descriptorType{DescriptorType::AKAZE}; + uint32_t m_id{0}; }; DECLARESERIALIZE(PointCloud); From 43c6f6c69f5277ac5f7a15cc535f318f24ef854b Mon Sep 17 00:00:00 2001 From: ccutullic Date: Wed, 27 Aug 2025 11:24:07 +0200 Subject: [PATCH 3/3] fix (datastructure): define a default constructor for PointCloud class --- interfaces/datastructure/PointCloud.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interfaces/datastructure/PointCloud.h b/interfaces/datastructure/PointCloud.h index e6f7c596..23eb59e5 100644 --- a/interfaces/datastructure/PointCloud.h +++ b/interfaces/datastructure/PointCloud.h @@ -42,7 +42,7 @@ class SOLARFRAMEWORK_API PointCloud : public Lockable { /// /// @brief PointCloud constructor. /// - PointCloud(); + PointCloud() = default; PointCloud(const PointCloud& other): m_pointCloud(other.m_pointCloud), m_descriptorType(other.m_descriptorType), m_id(other.m_id) {}; PointCloud& operator=(const PointCloud& /* other */) { return *this; };