Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the system settings and config #173

Merged
merged 14 commits into from Jun 9, 2017
Merged

Conversation

@pierredup
Copy link
Member

pierredup commented Jun 2, 2017

  • Remove all setting loaders and consolidate all the settings in one place
  • Change format of loading settings
  • Add custom form types for all settings
  • Remove different sections for the settings
  • Replace SettingsManager with SystemConfig class
@pierredup pierredup added the refactor label Jun 2, 2017
@pierredup pierredup added this to the 2.0.0 milestone Jun 2, 2017
@pierredup pierredup self-assigned this Jun 2, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 2, 2017

Coverage Status

Coverage decreased (-3.9%) to 22.82% when pulling f6c23c8 on pierredup:settings into 83f2666 on CSBill:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-2.6%) to 24.106% when pulling 9c37129 on pierredup:settings into 83f2666 on CSBill:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-2.6%) to 24.106% when pulling c5b8304 on pierredup:settings into 83f2666 on CSBill:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-2.6%) to 24.106% when pulling c5b8304 on pierredup:settings into 83f2666 on CSBill:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 8, 2017

Coverage Status

Coverage decreased (-2.009%) to 24.676% when pulling 40e2895 on pierredup:settings into 83f2666 on CSBill:master.

@pierredup pierredup force-pushed the pierredup:settings branch from 40e2895 to 1b699a6 Jun 8, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 8, 2017

Coverage Status

Coverage decreased (-2.009%) to 24.676% when pulling 1b699a6 on pierredup:settings into 83f2666 on CSBill:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage decreased (-2.009%) to 24.676% when pulling 33fab95 on pierredup:settings into 83f2666 on CSBill:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage decreased (-2.009%) to 24.676% when pulling 33fab95 on pierredup:settings into 83f2666 on CSBill:master.

@pierredup pierredup merged commit a384012 into SolidInvoice:master Jun 9, 2017
4 of 5 checks passed
4 of 5 checks passed
coverage/coveralls Coverage decreased (-2.009%) to 24.676%
Details
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details
@pierredup pierredup deleted the pierredup:settings branch Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.