Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper required PHP version in AppRequirements #185

Merged
merged 1 commit into from Aug 20, 2017

Conversation

@pierredup
Copy link
Member

pierredup commented Aug 20, 2017

Overwrite the getPhpRequiredVersion method in the requirements file to set the proper minimum required PHP version. This helps to not display 2 different minimum versions on the requirements page

@pierredup pierredup added this to the 2.0.0 milestone Aug 20, 2017
@pierredup pierredup self-assigned this Aug 20, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 20, 2017

Coverage Status

Coverage remained the same at 30.169% when pulling ba2e93d on pierredup:requirements-update into e410cb0 on CSBill:master.

@pierredup pierredup merged commit 00ea1cb into SolidInvoice:master Aug 20, 2017
5 checks passed
5 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 30.169%
Details
security/snyk No new vulnerabilities
Details
@pierredup pierredup deleted the pierredup:requirements-update branch Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.