Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set quote items by reference #217

Merged
merged 1 commit into from Oct 12, 2018

Conversation

@pierredup
Copy link
Member

pierredup commented Oct 12, 2018

When setting quote items by reference, the addItem method is never called on the entity, which causes the item to never be attached to the specific quote

@pierredup pierredup self-assigned this Oct 12, 2018
@pierredup pierredup added this to the 2.0.0 milestone Oct 12, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 12, 2018

Coverage Status

Coverage remained the same at 37.09% when pulling bef8874 on pierredup:fix-quote-reference into a5a5b57 on SolidInvoice:master.

@pierredup pierredup merged commit bb4579b into SolidInvoice:master Oct 12, 2018
2 of 4 checks passed
2 of 4 checks passed
Scrutinizer Analysis: 1 updated code elements – Tests: errored
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/styleci/pr The analysis has passed
Details
coverage/coveralls Coverage remained the same at 37.09%
Details
@pierredup pierredup deleted the pierredup:fix-quote-reference branch Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.