Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix totals not updating if no values are set #218

Merged
merged 1 commit into from Oct 12, 2018

Conversation

@pierredup
Copy link
Member

pierredup commented Oct 12, 2018

When adding a new row to a quote or invoice and no values are set (qty or amount), then the totals would change to 0 even if there are other rows with values.

@pierredup pierredup self-assigned this Oct 12, 2018
@pierredup pierredup added this to the 2.0.0 milestone Oct 12, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 12, 2018

Coverage Status

Coverage remained the same at 37.09% when pulling e1be6ee on pierredup:fix-totals into a5a5b57 on SolidInvoice:master.

@pierredup pierredup merged commit ac57707 into SolidInvoice:master Oct 12, 2018
2 of 4 checks passed
2 of 4 checks passed
Scrutinizer Analysis: 2 new issues, 1 updated code elements – Tests: errored
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/styleci/pr The analysis has passed
Details
coverage/coveralls Coverage remained the same at 37.09%
Details
@pierredup pierredup deleted the pierredup:fix-totals branch Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.