Feat/policy endpoint examples#60
Merged
woutslabbinck merged 8 commits intoAug 18, 2025
Merged
Conversation
woutslabbinck
requested changes
Aug 18, 2025
Contributor
woutslabbinck
left a comment
woutslabbinck
left a comment
There was a problem hiding this comment.
Looks good already.
It needs some minor tweaks, but this should not take a lot of time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added examples in the policy management endpoint documentation for the PUT, PATCH and DELETE endpoints. All examples when executed sequentially without leaving one out. I could write a test for this, but I'm not sure that is anything useful to do.
I also noticed that there is a minor discrepancy in the code handling the PATCH requests. The documentation states that these requests should include the
Content-Type: application/sparql-queryheader, yet the code checks forContent-Type: application/sparql-update. I didn't change any of these, but the example usesapplication/sparql-updateto make it work.I tracked a small mistake in EditPolicies where the error message wouldn't be printed. Solution is pretty straightforward. Didn't include, but I can sync my local changes immediately if allowed.