feat: Support client IDs in ODRL policies #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachimvh
force-pushed
the
feat/clientid
branch
from
688df65 to
b4e131b
Compare
Collaborator
|
How hard would it be to add a change into the evaluator without Wout? 🤔 Because this is really U G L Y 🙈 |
Contributor
Author
|
Since only specific constraints are supported I worry about diving in there, as I first expected all constraints to work the same 😅. My hope is that this will be resolved soon and we can all forget this happened. 😀 |
Collaborator
|
Well, isn't it easy to just add one specific constraint extra? Could probably be a copy of the purpose one... I haven't checked the code though, so if this PR is easier, you can go ahead |
joachimvh
force-pushed
the
feat/standard-oidc
branch
from
32eecfa to
b139bc5
Compare
I wanted to use the `odrl:deliveryChannel` constraint for this, but unfortunately v0.5.0 of the ODRL evaluator only supports `odrl:purpose` and `odrl:dateTime`. See https://github.com/SolidLabResearch/ODRL-Evaluator/blob/v0.5.0/ODRL-Support.md#left-operands. Since we are not yet using `odrl:purpose`, I'm using that one until this is resolved, as this feature is required sooner than purpose support, with the (hopefully not too naive) idea to resolve this soon.
joachimvh
force-pushed
the
feat/clientid
branch
from
b4e131b to
9d3bf03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68.
I wanted to use the
odrl:deliveryChannelconstraint for this, but unfortunately v0.5.0 of the ODRL evaluator only supportsodrl:purposeandodrl:dateTime. See https://github.com/SolidLabResearch/ODRL-Evaluator/blob/v0.5.0/ODRL-Support.md#left-operands. Since we are not yet usingodrl:purpose, I'm using that one until this is resolved, as this feature is required sooner than purpose support, with the (hopefully not too naive) idea to resolve this soon.