From 053ddc7efea45bfdbc5dbc4f52ea47901874c409 Mon Sep 17 00:00:00 2001 From: Tim Berners-Lee Date: Wed, 28 Aug 2019 14:59:30 -0400 Subject: [PATCH 1/2] work --- src/test/test-tabs.html | 60 ++++++++++++++++++++--------------------- src/test/test-tabs.js | 4 +-- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/src/test/test-tabs.html b/src/test/test-tabs.html index ab557cb97..5d5404533 100644 --- a/src/test/test-tabs.html +++ b/src/test/test-tabs.html @@ -12,7 +12,7 @@ - @@ -74,7 +74,7 @@

Test Tabs widget

trip:attachmentList ( <http://aclu.org/> <http://cnn.com/> <https://webfoundation.org/> ) . #ends - + @@ -91,7 +91,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -108,7 +108,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -125,7 +125,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -144,7 +144,7 @@

Test Tabs widget

trip:attachmentList ( <http://acm.org/> <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> <http://www.zenith.org/> ) . - + @@ -169,7 +169,7 @@

Test Tabs widget

<http://aclu.org/> <http://acm.org/> ) . - + @@ -186,7 +186,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <https://webfoundation.org/> ) . - + @@ -202,7 +202,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -219,7 +219,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -236,7 +236,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -253,7 +253,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -272,7 +272,7 @@

Test Tabs widget

trip:attachmentList ( <http://acm.org/> <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> <http://www.zenith.org/> ) . - + @@ -297,7 +297,7 @@

Test Tabs widget

<http://aclu.org/> <http://acm.org/> ) . - + @@ -314,7 +314,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <https://webfoundation.org/> ) . - + @@ -330,7 +330,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -347,7 +347,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -364,7 +364,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -381,7 +381,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -400,7 +400,7 @@

Test Tabs widget

trip:attachmentList ( <http://acm.org/> <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> <http://www.zenith.org/> ) . - + @@ -425,7 +425,7 @@

Test Tabs widget

<http://aclu.org/> <http://acm.org/> ) . - + @@ -442,7 +442,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <https://webfoundation.org/> ) . - + @@ -458,7 +458,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -475,7 +475,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <https://webfoundation.org/> ) . - + @@ -492,7 +492,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -509,7 +509,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> ) . - + @@ -528,7 +528,7 @@

Test Tabs widget

trip:attachmentList ( <http://acm.org/> <http://aclu.org/> <http://bbc.co.uk/> <http://cbc.ca/> <http://dbp.de/> <https://webfoundation.org/> <http://www.zenith.org/> ) . - + @@ -553,7 +553,7 @@

Test Tabs widget

<http://aclu.org/> <http://acm.org/> ) . - + @@ -570,7 +570,7 @@

Test Tabs widget

ui:subject <#it>. <#it> trip:attachmentList ( <https://webfoundation.org/> ) . - + diff --git a/src/test/test-tabs.js b/src/test/test-tabs.js index ef6db6647..35bde7fc0 100644 --- a/src/test/test-tabs.js +++ b/src/test/test-tabs.js @@ -2,7 +2,7 @@ document.addEventListener('DOMContentLoaded', function () { /// /////////////////////////////////////////// - var UI = require('mashlib') + var UI = panes.UI var kb = UI.store var dom = document @@ -60,7 +60,7 @@ document.addEventListener('DOMContentLoaded', function () { var tabContentCache = [] - options.showMain = function (container, subject) { + options.renderMain = function (container, subject) { container.innerHTML = '' if (tabContentCache[subject.uri]) { container.appendChild(tabContentCache[subject.uri]) From 27725d3c6ad667f59500504eef07c2112bc8feb5 Mon Sep 17 00:00:00 2001 From: Tim Berners-Lee Date: Wed, 28 Aug 2019 15:33:26 -0400 Subject: [PATCH 2/2] add close button to test --- src/test/test-tabs.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/test-tabs.js b/src/test/test-tabs.js index 35bde7fc0..ee8ca3c93 100644 --- a/src/test/test-tabs.js +++ b/src/test/test-tabs.js @@ -48,7 +48,8 @@ document.addEventListener('DOMContentLoaded', function () { options.subject = kb.the(target, UI.ns.ui('subject')) options.ordered = kb.the(target, UI.ns.ui('ordered')).value === '1' options.orientation = kb.the(target, UI.ns.ui('orientation')).value - + options.onClose = function(e) {} // Test it can make a close button is a good place + // todo: test both cases var tabs = div.appendChild(UI.tabs.tabWidget(options)) return tabs }