From 3f687ce22ceefbbb66f534005a2e9eb2cdea1da8 Mon Sep 17 00:00:00 2001 From: Arne Hassel Date: Thu, 8 Aug 2019 17:24:24 +0200 Subject: [PATCH 1/2] This should make the model correct wrt default values --- src/widgets/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/widgets/index.js b/src/widgets/index.js index 45185ff19..d5a505014 100644 --- a/src/widgets/index.js +++ b/src/widgets/index.js @@ -907,7 +907,9 @@ UI.widgets.field[UI.ns.ui('PhoneField').uri] = var obj = kb.any(subject, property, undefined, store) if (!obj) { obj = kb.any(form, ui('default')) - if (obj) kb.add(subject, property, obj, store) + if (obj) { + kb.add(subject, ui('default'), obj, store) + } } if (obj && obj.uri && params.uriPrefix) { // eg tel: or mailto: field.value = decodeURIComponent(obj.uri.replace(params.uriPrefix, '')) // should have no spaces but in case From b1c6b6b273cc7a537f1b065c7be8311cedab7671 Mon Sep 17 00:00:00 2001 From: Arne Hassel Date: Thu, 8 Aug 2019 17:56:51 +0200 Subject: [PATCH 2/2] Removing faulty logic -> This should handle the default value logic --- src/widgets/index.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/widgets/index.js b/src/widgets/index.js index d5a505014..cdcbe201d 100644 --- a/src/widgets/index.js +++ b/src/widgets/index.js @@ -904,13 +904,8 @@ UI.widgets.field[UI.ns.ui('PhoneField').uri] = store = store || UI.widgets.fieldStore(subject, property, store) - var obj = kb.any(subject, property, undefined, store) - if (!obj) { - obj = kb.any(form, ui('default')) - if (obj) { - kb.add(subject, ui('default'), obj, store) - } - } + var obj = kb.any(subject, property, undefined, store) || + kb.any(form, ui('default')) if (obj && obj.uri && params.uriPrefix) { // eg tel: or mailto: field.value = decodeURIComponent(obj.uri.replace(params.uriPrefix, '')) // should have no spaces but in case .replace(/ /g, '')