Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpacked map names and mapinfos entries will collide on merge #4

Closed
akesterson opened this issue Jun 4, 2014 · 1 comment
Closed

Unpacked map names and mapinfos entries will collide on merge #4

akesterson opened this issue Jun 4, 2014 · 1 comment
Labels
bug

Comments

@akesterson
Copy link
Collaborator

@akesterson akesterson commented Jun 4, 2014

The original RGSS serialization code I ganked from SiCrane exports the Map YAML files to "YAML/MapXXX.yaml" where XXX is the map's index number (position in the map list, from top to bottom), which is also its index into the YAML/MapInfos.yaml file which contains map name information & such. It's a very safe way to generate the YAML files, since it will allow them to be ordered by the filesystem into the correct order, and it will prevent any unicode or other strange characters in a mapname from giving the filesystem fits. But it will lead to namespace collisions in the filesystem if (for example) the game has 10 maps, 2 developers both create a new map and try to merge back to trunk - they'll both be trying to send back "YAML/Map011.yaml", and this will create a merge conflict that someone will have to resolve (because the two filenames will collide).

This needs to be resolved. Unfortunately the way the serializer is written it's not going to be as fast of a fix as I thought.

@akesterson akesterson added the bug label Jun 4, 2014
@akesterson
Copy link
Collaborator Author

@akesterson akesterson commented Jun 7, 2014

See the "Workflow : Avoiding Map Collisions" and "Why rvpacker can't help with map collisions" in the README file.

Won't fix, too hard.

@akesterson akesterson closed this Jun 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.