Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
remove LD hacks #123
Makefile.common included first Makeconf, and set AS, CC, LD unconditionally
It turns out (I didn't yet dig which commit) that FreeBSD's ld (version 2.17.50)
This commit a) removes the LD detection (executed on FreeBSD only), b) moves the .include in Makefile.common to a later point so that we can actually override these variables in Makeconf. It worked before #106, but not after (before
And here with 2.27:
I tested this with a FreeBSD-CURRENT (the ld in RELENG_11 is the same, as it is in FreeBSD-11 RELEASE). Would be great if someone else could test this PR and verify that the linker issue is really gone.
referenced this pull request
Nov 20, 2016
At first glance this seems OK. I also noticed that at some point the standard FreeBSD
Just to confirm, the two
As far as I can tell there have been no changes to the FreeBSD system
sure. I was surprised by this as well. FreeBSD has not changed its
I've done some more tests with the Solo5 standalone tests and stackv4. The only material difference in
My theory is this is due to the newer (GNU) ld being smarter about removing unneeded output sections. So, this change should not break anything. However: binaries linked with the system ld will be slightly larger on disk and in memory (the difference with stackv4 is about 57kB).
@hannesm If you're OK with the above analysis and caveat then I'm happy to merge this.