xen console: update the "to be written" count#538
Merged
Conversation
Closed
talex5
reviewed
Dec 5, 2022
palainp
force-pushed
the
xen-fix-console
branch
from
2935f9c to
ae02183
Compare
palainp
force-pushed
the
xen-fix-console
branch
from
ae02183 to
099be86
Compare
Contributor
|
looks fine to me, a regression test could be added here in the solo5 test suite (the behaviour should be reproducible without any mirageos / ocaml involved). |
avsm
approved these changes
Dec 5, 2022
avsm
left a comment
avsm
left a comment
Collaborator
There was a problem hiding this comment.
Fix looks right to me. If anyone has some time, a 'console stress test' would be a useful regression test to have for all the backends.
hannesm
added a commit
to hannesm/solo5
that referenced
this pull request
Dec 6, 2022
hannesm
added a commit
to hannesm/solo5
that referenced
this pull request
Dec 6, 2022
hannesm
added a commit
to hannesm/solo5
that referenced
this pull request
Dec 6, 2022
Collaborator
|
Thanks, the test is done by @hannesm, I will cut a release. |
palainp
pushed a commit
to palainp/solo5
that referenced
this pull request
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we can get an infinite loop as
writtenis the number of bytes written to the console returned byconsole_write_some(from 0 to itslenargument) (l111), then it's compared against len for teminating the loop (l126).The issue is that if
lenis greater than the Xen buffer size (2048B), we have to loop over the buffer and useconsole_write_somemore than one time (and it will return something in the interval[0,len-written[which will never equalslen(l126).The proposed patch
lower theincrease the written count until it reacheslenwhich will stand for "how many bytes I still have to write", and stops the loop when it comes to 0len. This fix #537.