Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to linker scripts / --nmagic #56

Merged
merged 2 commits into from Jul 1, 2016

Conversation

mato
Copy link
Member

@mato mato commented Jul 1, 2016

--nmagic has side effects which a) break ukvm and b) we don't want in general (results in a single RWX phdr for the entire kernel). Revert those changes, and introduce a possible workaround for FreeBSD.

mato added 2 commits July 1, 2016 17:16
This reverts commit 66a9ca0.

--nmagic has other side effects (loading everything in a single RWX
segment), which break ukvm among other things.
@mato
Copy link
Member Author

mato commented Jul 1, 2016

For the record, the workaround is here: https://sourceware.org/ml/binutils/2009-08/msg00512.html
(don't set OUTPUT_FORMAT() in linker scripts otherwise -z max-page-size does not work)

@mato mato merged commit 146d654 into Solo5:master Jul 1, 2016
@hannesm
Copy link
Contributor

hannesm commented Jul 1, 2016

this works on FreeBSD (compiles, and the resulting test_hello.virtio) boots!

@mato mato deleted the revert-ldscripts branch July 1, 2016 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants