Revert changes to linker scripts / --nmagic #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 66a9ca0. --nmagic has other side effects (loading everything in a single RWX segment), which break ukvm among other things.
Member
Author
|
For the record, the workaround is here: https://sourceware.org/ml/binutils/2009-08/msg00512.html |
Contributor
|
this works on FreeBSD (compiles, and the resulting test_hello.virtio) boots! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--nmagic has side effects which a) break ukvm and b) we don't want in general (results in a single RWX phdr for the entire kernel). Revert those changes, and introduce a possible workaround for FreeBSD.