New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skaffold for local development #1054

Merged
merged 10 commits into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@AleF83
Copy link
Contributor

AleF83 commented Jan 9, 2019

Closes #1046

@wafflebot wafflebot bot added the in progress label Jan 9, 2019

AleF83 added some commits Jan 9, 2019

@AleF83 AleF83 requested a review from Yshayy Jan 13, 2019

AleF83 added some commits Jan 13, 2019

.
gateway.json: |
{
"upstreams": {
"api": "http://api",

This comment has been minimized.

@Yshayy

Yshayy Jan 14, 2019

Collaborator

Shouldn't these upstreams be in default with support for override/

"providers": {}
}
},
"v1Hosts": {

This comment has been minimized.

@Yshayy

Yshayy Jan 14, 2019

Collaborator

is v1Hosts need?

},
"basic_auth": {
"redirect_urls": [
"http://editor",

This comment has been minimized.

@Yshayy

Yshayy Jan 14, 2019

Collaborator

Http://editor can be removed I think

]
}
"security": {
"auth": {

This comment has been minimized.

@Yshayy

Yshayy Jan 14, 2019

Collaborator

Do we need security section? or in general this gateway.json? maybe have just one config file

@Yshayy

Yshayy approved these changes Jan 14, 2019

@AleF83 AleF83 merged commit db04a0a into master Jan 15, 2019

12 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/snyk - e2e/integration/package.json (Soluto Tel Aviv Public) No new issues
Details
license/snyk - e2e/ui/package.json (Soluto Tel Aviv Public) No new issues
Details
license/snyk - package.json (Soluto Tel Aviv Public) No new issues
Details
license/snyk - services/authoring/package.json (Soluto Tel Aviv Public) No new issues
Details
license/snyk - services/editor/package.json (Soluto Tel Aviv Public) No new issues
Details
security/snyk - e2e/integration/package.json (Soluto Tel Aviv Public) No new issues
Details
security/snyk - e2e/ui/package.json (Soluto Tel Aviv Public) No new issues
Details
security/snyk - package.json (Soluto Tel Aviv Public) No new issues
Details
security/snyk - services/authoring/package.json (Soluto Tel Aviv Public) No new issues
Details
security/snyk - services/editor/package.json (Soluto Tel Aviv Public) No new issues
Details
tweek-all Build passed
Details

@wafflebot wafflebot bot removed the in progress label Jan 15, 2019

@AleF83 AleF83 deleted the 1046-skaffold branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment