New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor] Upgrade editor packages #1108

Merged
merged 13 commits into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@nataly87s
Copy link
Contributor

nataly87s commented Feb 7, 2019

No description provided.

@nataly87s nataly87s requested a review from Yshayy Feb 7, 2019

@wafflebot wafflebot bot added the in progress label Feb 7, 2019

@nataly87s nataly87s force-pushed the upgrade-editor-packages branch from 1bbbd18 to 5cf2d04 Feb 7, 2019

@Yshayy

Yshayy approved these changes Feb 7, 2019


<FixedKeysList {...{ keys, onChange, toggleDelete }} />
state = { formattedKeys: undefined };

This comment has been minimized.

@Yshayy

Yshayy Feb 7, 2019

Collaborator

What's the use of state here? (it doesn't look like it's updated)

This comment has been minimized.

@nataly87s

nataly87s Feb 7, 2019

Author Contributor

it's updated in getDerivedStateFromProps

This comment has been minimized.

@nataly87s

nataly87s Feb 7, 2019

Author Contributor

there won't be any use for at when we move to hooks

This comment has been minimized.

@Yshayy

Yshayy Feb 7, 2019

Collaborator

Couldn't it be just getter?

This comment has been minimized.

@nataly87s

nataly87s Feb 7, 2019

Author Contributor

I didn't want to calculate it every time.
I started upgrading to hooks (🎉) so it will go away

@nataly87s nataly87s merged commit d515955 into master Feb 7, 2019

12 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/snyk - e2e/integration/package.json (Soluto Public) No new issues
Details
license/snyk - e2e/ui/package.json (Soluto Public) No new issues
Details
license/snyk - package.json (Soluto Public) No new issues
Details
license/snyk - services/authoring/package.json (Soluto Public) No new issues
Details
license/snyk - services/editor/package.json (Soluto Public) No new issues
Details
security/snyk - e2e/integration/package.json (Soluto Public) No new issues
Details
security/snyk - e2e/ui/package.json (Soluto Public) No new issues
Details
security/snyk - package.json (Soluto Public) No new issues
Details
security/snyk - services/authoring/package.json (Soluto Public) No new issues
Details
security/snyk - services/editor/package.json (Soluto Public) No new issues
Details
tweek-all Build passed
Details

@nataly87s nataly87s deleted the upgrade-editor-packages branch Feb 7, 2019

@wafflebot wafflebot bot removed the in progress label Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment