Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appmetrics prometheus formatter #1121

Merged
merged 3 commits into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@shaikatz
Copy link
Contributor

shaikatz commented Mar 11, 2019

Prometheus is now more strict about the metric capitalization. Issue
We should use the new version otherwise Prometheus version 2.4 and above will fail to scrape the metrics.

@shaikatz shaikatz requested a review from Yshayy Mar 11, 2019

@wafflebot wafflebot bot added the in progress label Mar 11, 2019

@Yshayy
Copy link
Collaborator

Yshayy left a comment

Better to bump version as well, to 1.0.0-rc2

@Yshayy

This comment has been minimized.

Copy link
Collaborator

Yshayy commented Mar 11, 2019

/cf-test

@shaikatz

This comment has been minimized.

Copy link
Contributor Author

shaikatz commented Mar 11, 2019

@Yshayy Version bumped.

@Yshayy

This comment has been minimized.

Copy link
Collaborator

Yshayy commented Mar 12, 2019

/cf-test

@Yshayy

This comment has been minimized.

Copy link
Collaborator

Yshayy commented Mar 12, 2019

Are the metrics format different in 3.0?

@shaikatz

This comment has been minimized.

Copy link
Contributor Author

shaikatz commented Mar 12, 2019

This is the only breaking change AppMetrics/AspNetCore#27

@Yshayy Yshayy merged commit 76742f6 into Soluto:master Mar 12, 2019

12 of 14 checks passed

license/snyk - services/api/Tweek.ApiService/Tweek.ApiService.csproj (Soluto Public) Test in progress
license/snyk - services/publishing/Tweek.Publishing.Service/Tweek.Publishing.Service.csproj (Soluto Public) Test in progress
ci/circleci: build Your tests passed on CircleCI!
Details
license/snyk - package.json (Soluto Public) No high severity issues
Details
license/snyk - services/api/Tweek.ApiService/Tweek.ApiService.csproj - netcoreapp2.1 (Soluto Public) No high severity issues
Details
license/snyk - services/authoring/package.json (Soluto Public) No high severity issues
Details
license/snyk - services/editor/package.json (Soluto Public) No high severity issues
Details
license/snyk - services/publishing/Tweek.Publishing.Service/Tweek.Publishing.Service.csproj - netcoreapp2.1 (Soluto Public) No high severity issues
Details
security/snyk - package.json (Soluto Public) No high severity issues
Details
security/snyk - services/api/Tweek.ApiService/Tweek.ApiService.csproj - netcoreapp2.1 (Soluto Public) No high severity issues
Details
security/snyk - services/authoring/package.json (Soluto Public) No high severity issues
Details
security/snyk - services/editor/package.json (Soluto Public) No high severity issues
Details
security/snyk - services/publishing/Tweek.Publishing.Service/Tweek.Publishing.Service.csproj - netcoreapp2.1 (Soluto Public) No high severity issues
Details
tweek-pr Build passed
Details

@wafflebot wafflebot bot removed the in progress label Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.