GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we have to have separate glue installations in the tests?
where is it used?
Are you referring to ruby?
Do we have to run Glue inside the e2e/integration/smoke tests image, or can we run it in a stand alone container (or aside the proxy) that collect the reports after the tests finish running?
We can - but it will make the things a lot more complicated - you will have to somehow call this container at the end of each one of the tests (API maybe?).
@michaelkruglos do you mean if we need to have 2 different installations of Glue?
Proxy smoke test and ui automation through Zap
Use Glue to get findings from Zap
Fix API findings - ignore all false positive
Fix editor: added helmet and SameSite to cookie
ignore false positive in the editor
I think the only thing that is worth considering, is doing the glue stuff in separate steps from actual tests.
But we can do it in another PR
@Yshayy there is already an issue for that - see #644