New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DAST to tweek #633

Merged
merged 5 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@omerlh
Contributor

omerlh commented Oct 22, 2017

close #235
WIP

@omerlh omerlh requested a review from Yshayy Oct 22, 2017

@michaelkruglos

Do we have to have separate glue installations in the tests?

Show outdated Hide outdated CI/codefresh.yml Outdated
ENV RUBY_MAJOR 2.4
ENV RUBY_VERSION 2.4.2
ENV RUBY_DOWNLOAD_SHA256 748a8980d30141bd1a4124e11745bb105b436fb1890826e0d2b9ea31af27f735

This comment has been minimized.

@michaelkruglos

michaelkruglos Nov 5, 2017

Contributor

where is it used?

@michaelkruglos

michaelkruglos Nov 5, 2017

Contributor

where is it used?

This comment has been minimized.

@omerlh

omerlh Nov 5, 2017

Contributor

Are you referring to ruby?

@omerlh

omerlh Nov 5, 2017

Contributor

Are you referring to ruby?

This comment has been minimized.

@Yshayy

Yshayy Nov 5, 2017

Contributor

Do we have to run Glue inside the e2e/integration/smoke tests image, or can we run it in a stand alone container (or aside the proxy) that collect the reports after the tests finish running?

@Yshayy

Yshayy Nov 5, 2017

Contributor

Do we have to run Glue inside the e2e/integration/smoke tests image, or can we run it in a stand alone container (or aside the proxy) that collect the reports after the tests finish running?

This comment has been minimized.

@omerlh

omerlh Nov 5, 2017

Contributor

We can - but it will make the things a lot more complicated - you will have to somehow call this container at the end of each one of the tests (API maybe?).

@omerlh

omerlh Nov 5, 2017

Contributor

We can - but it will make the things a lot more complicated - you will have to somehow call this container at the end of each one of the tests (API maybe?).

@omerlh

This comment has been minimized.

Show comment
Hide comment
@omerlh

omerlh Nov 5, 2017

Contributor

@michaelkruglos do you mean if we need to have 2 different installations of Glue?

Contributor

omerlh commented Nov 5, 2017

@michaelkruglos do you mean if we need to have 2 different installations of Glue?

@Yshayy

Yshayy approved these changes Nov 7, 2017

I think the only thing that is worth considering, is doing the glue stuff in separate steps from actual tests.
But we can do it in another PR

@omerlh

This comment has been minimized.

Show comment
Hide comment
@omerlh

omerlh Nov 7, 2017

Contributor

@Yshayy there is already an issue for that - see #644

Contributor

omerlh commented Nov 7, 2017

@Yshayy there is already an issue for that - see #644

@omerlh omerlh merged commit d9834da into master Nov 7, 2017

2 checks passed

Codefresh Build passed
Details
VersionEye All software dependencies are fine. You are awesome!
Details

@nataly87s nataly87s deleted the security-tests branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment