From 399111673a2b0360fa60af1839fdcc5d89781739 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Garc=C3=ADa=20Garz=C3=B3n?=
 <david.garcia@somenergia.coop>
Date: Thu, 28 Dec 2023 07:49:06 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20changes=20required=20by=20sonar?=
 =?UTF-8?q?=20linter?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 backend/datasources/erp.py |  2 +-
 backend/erp.py             | 13 +++++--------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/backend/datasources/erp.py b/backend/datasources/erp.py
index f414ded7..0aab0766 100644
--- a/backend/datasources/erp.py
+++ b/backend/datasources/erp.py
@@ -39,7 +39,7 @@ def catch_validation_error():
     NoDocumentVersions,
 ]
 def process_erp_errors(erp_response):
-    if not 'error' in erp_response: return
+    if 'error' not in erp_response: return
     erp_errors = {
         excp.__name__: excp
         for excp in expected_erp_exceptions
diff --git a/backend/erp.py b/backend/erp.py
index 51206382..2f67fb5e 100644
--- a/backend/erp.py
+++ b/backend/erp.py
@@ -8,13 +8,10 @@
 # TODO; Use erppeek, connection pool management, transactions...
 
 @decorator
-def requiresToken(f, self, *args, **kwds):
-    try:
-        if not self._token:
-            self.token()
-        return f(self, *args, **kwds)
-    except Exception as e:
-        raise 
+def requires_token(f, self, *args, **kwds):
+    if not self._token:
+        self.token()
+    return f(self, *args, **kwds)
 
 class ErpConnectionError(Exception): pass
 
@@ -56,7 +53,7 @@ def _post(self, endpoint, *args):
     def token(self):
         self._token = self._post('/common', 'token', self.db, self.user, self.password)
 
-    @requiresToken
+    @requires_token
     def object_execute(self, *args):
         return self._post('/object', 'execute', self.db, 'token', self._token, *args)