diff --git a/src/main/java/org/sonar/plugins/scmstats/AbstractScmAdapter.java b/src/main/java/org/sonar/plugins/scmstats/AbstractScmAdapter.java index 8ffde99..6f88077 100644 --- a/src/main/java/org/sonar/plugins/scmstats/AbstractScmAdapter.java +++ b/src/main/java/org/sonar/plugins/scmstats/AbstractScmAdapter.java @@ -83,7 +83,7 @@ protected final boolean isIncluded(Resource resource) { protected Map updateActivity (String resourceName, Map fileStatus, String activity) { Resource resource = createResource(resourceName); LOG.warn(resource.getKey() + " is " + (isIncluded(resource) ? "NOT " : " ") + "excluded"); - return (isIncluded(resource) ? MapUtils.updateMap(fileStatus, activity) : fileStatus); + return isIncluded(resource) ? MapUtils.updateMap(fileStatus, activity) : fileStatus; } Resource createResource(String resourceName) { diff --git a/src/main/java/org/sonar/plugins/scmstats/HgScmAdapter.java b/src/main/java/org/sonar/plugins/scmstats/HgScmAdapter.java index c1d01f5..1947381 100644 --- a/src/main/java/org/sonar/plugins/scmstats/HgScmAdapter.java +++ b/src/main/java/org/sonar/plugins/scmstats/HgScmAdapter.java @@ -86,7 +86,7 @@ private List getHgChangeLog() { LOG.info("Getting change log information for %s\n", baseDir.getAbsolutePath()); if (!hgRepo.initFrom(baseDir)) { throw new HgRepositoryNotFoundException( - String.format("Can't find repository in: %s\n",baseDir.getAbsolutePath())); + String.format("Can't find repository in: %s%n",baseDir.getAbsolutePath())); } HgLogCommand cmd = hgRepo.createLogCommand(); return cmd.execute(); diff --git a/src/main/java/org/sonar/plugins/scmstats/measures/ChangeLogHandler.java b/src/main/java/org/sonar/plugins/scmstats/measures/ChangeLogHandler.java index 4edb4ac..d28434b 100644 --- a/src/main/java/org/sonar/plugins/scmstats/measures/ChangeLogHandler.java +++ b/src/main/java/org/sonar/plugins/scmstats/measures/ChangeLogHandler.java @@ -90,7 +90,7 @@ protected Map updateAuthorActivity( authorActivity.putAll(map); final Map activity = changeLogInfo.getActivity(); - List stats = (authorActivity.get(author) == null ? getInitialActivity(activity) : authorActivity.get(author).getCommits()); + List stats = authorActivity.get(author) == null ? getInitialActivity(activity) : authorActivity.get(author).getCommits(); if (authorActivity.containsKey(author)) { final Integer commits = stats.get(0) + 1; diff --git a/src/main/java/org/sonar/plugins/scmstats/utils/UrlChecker.java b/src/main/java/org/sonar/plugins/scmstats/utils/UrlChecker.java index 0da6bd4..6944e0b 100644 --- a/src/main/java/org/sonar/plugins/scmstats/utils/UrlChecker.java +++ b/src/main/java/org/sonar/plugins/scmstats/utils/UrlChecker.java @@ -27,7 +27,7 @@ import org.sonar.api.BatchExtension; public class UrlChecker implements BatchExtension { - public static final String PARAMETER_MESSAGE = String.format("SCM Stats Plugin will not run.Please check the parameter SCM URL or the section of Maven pom."); + public static final String PARAMETER_MESSAGE = "SCM Stats Plugin will not run.Please check the parameter SCM URL or the section of Maven pom."; public static final String FAILURE_BLANK = "SCM URL must not be blank"; public static final String FAILURE_FORMAT = "URL does not respect the SCM URL format described in http://maven.apache.org/scm/scm-url-format.html: [%s]"; public static final String FAILURE_NOT_SUPPORTED = "Unsupported SCM: [%s]. Check compatibility at http://docs.codehaus.org/display/SONAR/SCM+Stats+Plugin";