From 622c9ef5a959c347e649b814e8ecdd6b191bb2d5 Mon Sep 17 00:00:00 2001 From: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com> Date: Fri, 25 Aug 2023 16:01:56 +0200 Subject: [PATCH] Log the filename for which an issue is saved (#4111) --- .../sonar/plugins/javascript/eslint/AnalysisProcessor.java | 7 ++++++- .../sonar/plugins/javascript/eslint/JsTsSensorTest.java | 7 +++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/AnalysisProcessor.java b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/AnalysisProcessor.java index 2ce98c7ec7..0fe1bd0f98 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/AnalysisProcessor.java +++ b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/AnalysisProcessor.java @@ -175,7 +175,12 @@ private void processParsingError(BridgeServer.ParsingError parsingError) { private void saveIssues(List issues) { for (Issue issue : issues) { - LOG.debug("Saving issue for rule {} on line {}", issue.ruleId, issue.line); + LOG.debug( + "Saving issue for rule {} on file {} at line {}", + issue.ruleId, + file.absolutePath(), + issue.line + ); saveIssue(issue); } } diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/JsTsSensorTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/JsTsSensorTest.java index d1fdccd1eb..9ab332aef8 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/JsTsSensorTest.java +++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/JsTsSensorTest.java @@ -183,6 +183,13 @@ void should_analyse() throws Exception { sensor.execute(context); verify(bridgeServerMock, times(1)).initLinter(any(), any(), any(), any()); assertThat(context.allIssues()).hasSize(expectedResponse.issues.size()); + assertThat(logTester.logs(LoggerLevel.DEBUG)) + .contains( + String.format( + "Saving issue for rule no-all-duplicated-branches on file %s at line 1", + inputFile.absolutePath() + ) + ); Iterator issues = context.allIssues().iterator(); Issue firstIssue = issues.next();