Skip to content

DOCKER-164: Add org.opencontainers.image.url label #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

candrews
Copy link
Contributor

@candrews candrews commented Mar 1, 2023

Add the org.opencontainers.image.url label to the docker image.

These annotations are useful for people to manual use as well as for use by tools. For example, Snyk uses them in its UI and Renovate uses them to find release notes.

See: https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys

See: SonarSource/sonar-scanner-cli-docker#160


Please be aware that we are not actively looking for feature contributions. We typically accept minor improvements and bug-fixes.
Please ensure your pull request adheres to the following guidelines:

  • explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • If the PR modifies or adds images, use the run-tests.sh imagedir command to verify the image works
  • If the PR modifies or adds images, try to make sure the images run correctly on Linux

Add the org.opencontainers.image.url label to the docker image.

These annotations are useful for people to manual use as well as for use by tools. For example, Snyk uses them in its UI and Renovate uses them to find release notes.

See: https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @candrews,

as mentioned in the other PR, thanks again for your contribution! We integrate your suggested label! We'll investigate which of the other annotations available here should be added to our images in the context of this task DOCKER-164.

@carminevassallo carminevassallo merged commit 4b5c51d into SonarSource:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants