Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast for SonarScanner for MSBuild <= 3.0 #3593

Closed
pavel-mikula-sonarsource opened this issue Sep 3, 2020 · 0 comments · Fixed by #3595
Closed

Fail fast for SonarScanner for MSBuild <= 3.0 #3593

pavel-mikula-sonarsource opened this issue Sep 3, 2020 · 0 comments · Fixed by #3595
Assignees
@pavel-mikula-sonarsource
Labels
Area: SQ Plugin Java plugin related issues.
Projects
Best Kanban
Milestone
8.13

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Sep 3, 2020 •
edited

Support for SonarScanner for MSBuild 3.0 was removed in previous release 8.12

We should fail fast the analysis in case that the roslyn.reportFilePaths property is missing for all projects (SQ modules).

We cannot fail fast when analyzer.projectOutPaths is missing because we intentionally don't generate the property for test projects. And solution containing only test projects would fail to analyze.
@pavel-mikula-sonarsource pavel-mikula-sonarsource added the Area: SQ Plugin Java plugin related issues. label Sep 3, 2020
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 8.13 milestone Sep 3, 2020
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from To do to In progress in Best Kanban Sep 4, 2020
Merged
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from In progress to Review in progress in Best Kanban Sep 4, 2020
@andrei-epure-sonarsource andrei-epure-sonarsource moved this from Review in progress to In progress in Best Kanban Sep 4, 2020
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from In progress to Review in progress in Best Kanban Sep 4, 2020
@andrei-epure-sonarsource andrei-epure-sonarsource moved this from Review in progress to Reviewer approved in Best Kanban Sep 7, 2020
Best Kanban automation moved this from Reviewer approved to Done Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
Area: SQ Plugin Java plugin related issues.
Projects
Best Kanban
  
Done
Milestone
8.13
Development

Successfully merging a pull request may close this issue.

Fail fast for SonarScanner for MSBuild <= 3.0 SonarSource/sonar-dotnet
2 participants
@andrei-epure-sonarsource @pavel-mikula-sonarsource