Remove language property from SonarLintXmlReader #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
changed the base branch from
master
to
feature/SL-exclusions-inclusions
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
changed the title
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
mary-georgiou-sonarsource
added
Sprint: SonarLint
Sprint: Hardening
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/remove-language-parameter
branch
2 times, most recently
from
28f2a29
to
6f3a31d
Compare
pavel-mikula-sonarsource
changed the title
mary-georgiou-sonarsource
requested a review
from cristian-ambrosini-sonarsource
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned pavel-mikula-sonarsource
cristian-ambrosini-sonarsource
approved these changes
Mar 13, 2023
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/AnalysisContext/SonarAnalysisContextBaseTest.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned cristian-ambrosini-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
mary-georgiou-sonarsource
moved this from Review approved
to Review in progress
in Best Kanban
mary-georgiou-sonarsource
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
requested changes
Mar 13, 2023
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
pavel-mikula-sonarsource
requested changes
Mar 15, 2023
...sts/SonarAnalyzer.UnitTest/AnalysisContext/SonarAnalysisContextBaseTest.ShouldAnalyzeTree.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
requested changes
Mar 15, 2023
| [TestMethod] | ||
| public void Message_CS_String_Ctor() => | ||
| new UnexpectedLanguageException("C#").Message.Should().Be("Unexpected language: C#"); | ||
|
|
||
| [TestMethod] | ||
| public void Message_VB_String_Ctor() => | ||
| new UnexpectedLanguageException("Visual Basic").Message.Should().Be("Unexpected language: Visual Basic"); |
There was a problem hiding this comment.
Ideas:
- We don't need this twice.
- If we would, it would be better to use
LanguagesNames.Xxx. - _CS and _VB is typically used as a final suffix in the name
Solution: Just use some random value once instead
Suggested change
| [TestMethod] | |
| public void Message_CS_String_Ctor() => | |
| new UnexpectedLanguageException("C#").Message.Should().Be("Unexpected language: C#"); | |
| [TestMethod] | |
| public void Message_VB_String_Ctor() => | |
| new UnexpectedLanguageException("Visual Basic").Message.Should().Be("Unexpected language: Visual Basic"); | |
| [TestMethod] | |
| public void Message_String_Ctor() => | |
| new UnexpectedLanguageException("Xxx").Message.Should().Be("Unexpected language: Xxx"); |
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
pavel-mikula-sonarsource
approved these changes
Mar 15, 2023
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned mary-georgiou-sonarsource
|
There's one last nitpick hidden in the unresolved conversations above |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
mary-georgiou-sonarsource
merged commit f0553a7
into
feature/SL-exclusions-inclusions
22 checks passed
csaba-sagi-sonarsource
pushed a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Addresses comments from #6870